GradientSimilarity explanations images.#695
Merged
RobertSamoilescu merged 6 commits intoSeldonIO:masterfrom Jun 10, 2022
Merged
GradientSimilarity explanations images.#695RobertSamoilescu merged 6 commits intoSeldonIO:masterfrom
RobertSamoilescu merged 6 commits intoSeldonIO:masterfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 80.55% 80.55%
=======================================
Files 105 105
Lines 11790 11790
=======================================
Hits 9497 9497
Misses 2293 2293 |
RobertSamoilescu
force-pushed
the
similarity-imgs
branch
from
7cec016 to
395e308
Compare
RobertSamoilescu
force-pushed
the
similarity-imgs
branch
from
395e308 to
a6dbc73
Compare
jklaise
suggested changes
Jun 10, 2022
Contributor
jklaise
left a comment
jklaise
left a comment
There was a problem hiding this comment.
Looks good! A couple of minor suggestions:
- The figure captions could be made more obvious that they're captions, e.g. by using italics
- could you remove the
[source]link at the top as it's not leading anywhere?
jklaise
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two images in the method description for the GradientSimilarity.