ALE custom grid points update.#731
Merged
RobertSamoilescu merged 3 commits intoSeldonIO:masterfrom Aug 5, 2022
Merged
Conversation
…ad of clamping to min/max value. Included test.
cca52fa to
cea649b
Compare
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 81.06% 81.12% +0.05%
==========================================
Files 105 105
Lines 11794 11828 +34
==========================================
+ Hits 9561 9595 +34
Misses 2233 2233
|
jklaise
approved these changes
Aug 4, 2022
alibi/explainers/ale.py
Outdated
| where 3 grid-points are smaller than the minimum value in `f`, and 2 grid-points are larger than the maximum \ | ||
| value in `f`. Grid-points outside the feature value range are clipped between the minimum and maximum \ | ||
| values of `f`. The grid-points considered will be: `(O|X) X O X O (X|O)`. | ||
| value in `f`. The empty leading and ending bins were removed. The grid-points considered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes behavior from:
to:
Note that the new approach is less strict in terms of the lower & upper bound of the grid. This further allows
custom lower/upper grid values to be considered (previously the grid points were clamped to the min/max feature values) for which the ALE is still well defined.
The PR also includes a stress test for custom grid points.