Skip to content

Fix/protoselect test coverage#841

Merged
jklaise merged 3 commits intoSeldonIO:masterfrom
RobertSamoilescu:fix/protoselect-test-coverage
Jan 4, 2023
Merged

Fix/protoselect test coverage#841
jklaise merged 3 commits intoSeldonIO:masterfrom
RobertSamoilescu:fix/protoselect-test-coverage

Conversation

@RobertSamoilescu
Copy link
Contributor

This PR includes tests for the plotting functionality of ProtoSelect. Addresses #760

@RobertSamoilescu RobertSamoilescu force-pushed the fix/protoselect-test-coverage branch from 407adc6 to 6eafa5e Compare January 4, 2023 13:59
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RobertSamoilescu RobertSamoilescu force-pushed the fix/protoselect-test-coverage branch from 6eafa5e to 407adc6 Compare January 4, 2023 14:01
@RobertSamoilescu RobertSamoilescu force-pushed the fix/protoselect-test-coverage branch from 407adc6 to f4cd3fa Compare January 4, 2023 14:03
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #841 (178b07d) into master (69a3cac) will increase coverage by 0.61%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
+ Coverage   84.61%   85.22%   +0.61%     
==========================================
  Files          74       74              
  Lines        8727     8727              
==========================================
+ Hits         7384     7438      +54     
+ Misses       1343     1289      -54     
Flag Coverage Δ
macos-latest-3.10 85.09% <ø> (+0.52%) ⬆️
ubuntu-latest-3.10 85.09% <ø> (+0.61%) ⬆️
ubuntu-latest-3.7 84.98% <ø> (+0.72%) ⬆️
ubuntu-latest-3.8 85.11% <ø> (+0.71%) ⬆️
ubuntu-latest-3.9 85.11% <ø> (+0.62%) ⬆️
windows-latest-3.9 82.84% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi/prototypes/protoselect.py 93.36% <0.00%> (+27.55%) ⬆️

@RobertSamoilescu RobertSamoilescu force-pushed the fix/protoselect-test-coverage branch 2 times, most recently from 02fbdb2 to 178b07d Compare January 4, 2023 15:56
@jklaise jklaise merged commit 4eb6f18 into SeldonIO:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants