Replaced np.object with object in plot_permutation_importance.#872
Merged
jklaise merged 1 commit intoSeldonIO:masterfrom Feb 13, 2023
Merged
Replaced np.object with object in plot_permutation_importance.#872jklaise merged 1 commit intoSeldonIO:masterfrom
np.object with object in plot_permutation_importance.#872jklaise merged 1 commit intoSeldonIO:masterfrom
Conversation
Contributor
|
Note that I think the latest version the ci is run on is |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 85.28% 85.28%
=======================================
Files 74 74
Lines 8759 8759
=======================================
Hits 7470 7470
Misses 1289 1289
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
Can we check if this is backwards compatible with older versions of |
Contributor
|
Seems like should be fine from at least |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.objectis deprecated in latest release ofnumpy(1.24).