Skip to content

Replaced np.object with object in plot_permutation_importance.#872

Merged
jklaise merged 1 commit intoSeldonIO:masterfrom
RobertSamoilescu:fix/object-type
Feb 13, 2023
Merged

Replaced np.object with object in plot_permutation_importance.#872
jklaise merged 1 commit intoSeldonIO:masterfrom
RobertSamoilescu:fix/object-type

Conversation

@RobertSamoilescu
Copy link
Contributor

np.object is deprecated in latest release of numpy (1.24).

@mauicv
Copy link
Contributor

mauicv commented Feb 7, 2023

Note that I think the latest version the ci is run on is numpy==1.23.5. I think other libraries must be constraining the NumPy version.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #872 (fecfd06) into master (28b1597) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files          74       74           
  Lines        8759     8759           
=======================================
  Hits         7470     7470           
  Misses       1289     1289           
Flag Coverage Δ
macos-latest-3.10 ?
ubuntu-latest-3.10 85.23% <100.00%> (ø)
ubuntu-latest-3.7 85.14% <100.00%> (ø)
ubuntu-latest-3.8 85.07% <100.00%> (-0.10%) ⬇️
ubuntu-latest-3.9 85.17% <100.00%> (ø)
windows-latest-3.9 82.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi/explainers/permutation_importance.py 97.09% <100.00%> (ø)

@jklaise
Copy link
Contributor

jklaise commented Feb 13, 2023

Can we check if this is backwards compatible with older versions of numpy?

@jklaise
Copy link
Contributor

jklaise commented Feb 13, 2023

Seems like should be fine from at least 1.20: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants