Skip to content

Update logo path in readme#14177

Merged
diemol merged 3 commits intoSeleniumHQ:trunkfrom
nvborisenko:readme-logo
Jul 16, 2024
Merged

Update logo path in readme#14177
diemol merged 3 commits intoSeleniumHQ:trunkfrom
nvborisenko:readme-logo

Conversation

@nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Jun 23, 2024 •
edited by qodo-code-review bot
Loading

User description

Description

Changed a path to selenium logo to be more friendly with dark theme.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Documentation

Description

  • Updated the path to the Selenium logo image in the README file.
  • Changed the logo image to common/images/selenium_logo_medium.png to improve compatibility with dark themes.

Changes walkthrough 📝

Relevant files
Documentation
README.md
Update Selenium logo path for dark theme compatibility     

README.md

  • Updated the path to the Selenium logo image.
  • Changed the logo image to be more compatible with dark themes.
    		•  +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Jun 23, 2024

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 1
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Jun 23, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Use a relative path for the logo image to ensure compatibility across different environments

    Consider using a relative path for the logo image to ensure it works correctly in
    different environments, such as local development and various deployment setups.

    README.md [5]

    -<a href="https://selenium.dev"><img src="common/images/selenium_logo_medium.png" width="180" alt="Selenium Logo"/></a>
+<a href="https://selenium.dev"><img src="./common/images/selenium_logo_medium.png" width="180" alt="Selenium Logo"/></a>
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: The suggestion to use a relative path for the image source is valid for ensuring compatibility across different environments, but the existing path 'common/images/selenium_logo_medium.png' is already relative, making the impact of this suggestion minor.

    		6

    codespearhead
    codespearhead reviewed Jul 16, 2024
    View reviewed changes
    Copy link

    @codespearhead codespearhead left a comment •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The only visible difference is that this PR makes the white background of the logo become transparent [1][2], which seems to be the default way the logo is presented as per the official website, so LGTM.

    @diemol diemol merged commit 10b3305 into SeleniumHQ:trunk Jul 16, 2024
    @nvborisenko nvborisenko deleted the readme-logo branch July 20, 2024 17:13
    @x-way x-way mentioned this pull request Aug 10, 2024
    Closed
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Oct 29, 2024
    @nvborisenko @diemol @sandeepsuryaprasad
    Update logo path in readme (SeleniumHQ#14177)
    f25f184 
    * Update logo path in readme

* Path to svg is better

---------

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
    @MiguelPelegrina MiguelPelegrina mentioned this pull request Nov 8, 2024
    Open
    @titusfortner titusfortner added B-docs API Docs; see other repo for website documentation and removed documentation labels Mar 30, 2025
    M1troll pushed a commit to M1troll/selenium that referenced this pull request May 14, 2025
    @nvborisenko @diemol @M1troll
    Update logo path in readme (SeleniumHQ#14177)
    65c3de9 
    * Update logo path in readme

* Path to svg is better

---------

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @codespearhead codespearhead codespearhead left review comments

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    B-docs API Docs; see other repo for website documentation Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @nvborisenko @codespearhead @titusfortner @diemol