[dotnet] Improve bidi exception when it is not enabled

[nvborisenko]

PR Type

Bug fix

---

Description

• Replaced generic exception with a specific BiDiException.

• Improved error message for unsupported bidirectional protocol.

---

Changes walkthrough 📝

	Relevant files
Bug fix	WebDriver.Extensions.cs Refined exception handling and error message                          dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs Replaced System.Exception with BiDiException. Updated error message for better clarity. +1/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Null Reference The code uses null-forgiving operator (!) when calling ToString() on webSocketUrl, but there's no guarantee webSocketUrl is not null at that point. Consider adding a null check before calling ToString(). var bidi = await BiDi.ConnectAsync(webSocketUrl.ToString()!).ConfigureAwait(false);

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	✅ Add null parameter validation Suggestion Impact: The commit implements null validation for webDriver parameter using a different syntax than suggested code diff: + if (webDriver is null) throw new ArgumentNullException(nameof(webDriver)); Add null check for webDriver parameter to prevent NullReferenceException when calling the extension method with null dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs [29-31] public static async Task<BiDi> AsBiDiAsync(this IWebDriver webDriver) { + ArgumentNullException.ThrowIfNull(webDriver); var webSocketUrl = ((IHasCapabilities)webDriver).Capabilities.GetCapability("webSocketUrl"); Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding null parameter validation is crucial for preventing NullReferenceException and providing better error handling. This is a significant defensive programming practice that improves code robustness and provides clearer error messages.	8
Learned best practice	✅ Add proper validation for nullable values before using them to prevent potential runtime errors Suggestion Impact: The commit improves null handling by adding null checks for webDriver and properly handling webSocketUrl as a string, removing the null-forgiving operator code diff: + if (webDriver is null) throw new ArgumentNullException(nameof(webDriver)); + + string? webSocketUrl = null; + + if (webDriver is IHasCapabilities hasCapabilities) + { + webSocketUrl = hasCapabilities.Capabilities.GetCapability("webSocketUrl")?.ToString(); + } if (webSocketUrl is null) throw new BiDiException("The driver is not compatible with bidirectional protocol or \"webSocketUrl\" not enabled in driver options."); - var bidi = await BiDi.ConnectAsync(webSocketUrl.ToString()!).ConfigureAwait(false); + var bidi = await BiDi.ConnectAsync(webSocketUrl).ConfigureAwait(false); The code uses null-forgiving operator (!) on webSocketUrl.ToString() which could lead to runtime errors if webSocketUrl is null. Instead, validate the value before using it and provide a clear error message. dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs [33-35] -if (webSocketUrl is null) throw new BiDiException("The driver is not compatible with bidirectional protocol or \"webSocketUrl\" not enabled in driver options."); -var bidi = await BiDi.ConnectAsync(webSocketUrl.ToString()!).ConfigureAwait(false); +if (webSocketUrl is null) + throw new BiDiException("The driver is not compatible with bidirectional protocol or \"webSocketUrl\" not enabled in driver options."); +var webSocketUrlStr = webSocketUrl.ToString(); +if (string.IsNullOrEmpty(webSocketUrlStr)) + throw new BiDiException("Invalid empty webSocketUrl value"); + +var bidi = await BiDi.ConnectAsync(webSocketUrlStr).ConfigureAwait(false); + Apply this suggestion	6

[RenderMichael]

Better errors are always helpful.