[java] Ensure Selenium logging options are respected if java logging …

[pujagani]

User description

…properties are not set

Fixes #14160 and #15176

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Bug fix

---

Description

• Ensure Selenium logging options are respected when Java logging properties are unset.

• Prioritize Java logging configuration if explicitly set.

• Maintain existing loggers if Java logging configuration is provided.

---

Changes walkthrough 📝

	Relevant files
Bug fix	LoggingOptions.java Respect Java logging properties in Selenium logging configuration java/src/org/openqa/selenium/grid/log/LoggingOptions.java Added checks for Java logging configuration class and file properties. Ensured Selenium logging is used only if Java logging properties are unset. Updated logic to prioritize Java logging configuration over Selenium defaults. +8/-2

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Edge Case The new logging configuration check may not handle all edge cases where both Java logging properties and Selenium logging are configured. Consider validating the priority logic. String configClass = System.getProperty("java.util.logging.config.class"); String configFile = System.getProperty("java.util.logging.config.file"); // Check if the java logging config class or file is set. If so, give that priority. // Else default to the Selenium logging and respect the Selenium logging options. if (configClass != null || configFile != null) { return; }

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add null and empty string validation Add null check and trim for config properties to prevent potential NullPointerException and handle whitespace-only strings java/src/org/openqa/selenium/grid/log/LoggingOptions.java [101-106] String configClass = System.getProperty("java.util.logging.config.class"); String configFile = System.getProperty("java.util.logging.config.file"); -if (configClass != null || configFile != null) { +if ((configClass != null && configClass.trim().length() > 0) || + (configFile != null && configFile.trim().length() > 0)) { Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion improves robustness by handling edge cases where the config properties might be empty strings or contain only whitespace, preventing potential logical errors in the logging configuration selection.	7