[dotnet] Add nullability to Manage()#15210
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
* [dotnet] Add nullability to `Manage()` * Reference langword null on navigation
* [dotnet] Add nullability to `Manage()` * Reference langword null on navigation
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Add nullability to
Manage()Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Enabled nullable reference types across multiple files for improved null safety.
Refactored properties to use expression-bodied members for conciseness.
Added null checks and updated constructors to throw
ArgumentNullExceptionwhere necessary.Improved type safety by updating dictionary value types and handling potential null values.
Changes walkthrough 📝
IOptions.cs
Enable nullable reference types in `IOptions`dotnet/src/webdriver/IOptions.cs
#nullable enabledirective for null safety.ITimeouts.cs
Enable nullable reference types in `ITimeouts`dotnet/src/webdriver/ITimeouts.cs
#nullable enabledirective for null safety.IWindow.cs
Enable nullable reference types in `IWindow`dotnet/src/webdriver/IWindow.cs
#nullable enabledirective for null safety.OptionsManager.cs
Refactor `OptionsManager` and enable nullable reference typesdotnet/src/webdriver/OptionsManager.cs
OptionsManagerto a sealed class.Timeouts.cs
Refactor `Timeouts` and enable nullable reference typesdotnet/src/webdriver/Timeouts.cs
Window.cs
Refactor `Window` and enable nullable reference typesdotnet/src/webdriver/Window.cs
Windowto a sealed class.