You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The test is marked as expected to fail in remote environments, but the root cause should be investigated to determine if this is the best long-term solution versus fixing the underlying issue.
Excluding devtools_tests.py from Firefox test suite reduces test coverage. Consider if there are alternative approaches to handle Firefox-specific devtools testing.
driver.execute_script('console.log(document);')
-wait.until { !logs.empty? }+begin+ wait.until { !logs.empty? }+ expect(logs).to include(+ an_object_having_attributes(type: :log, args: [hash_including('type' => 'object')])+ )+rescue Selenium::WebDriver::Error::TimeoutError+ fail "Console logs were not received within the timeout period"+end-expect(logs).to include(- an_object_having_attributes(type: :log, args: [hash_including('type' => 'object')])-)-
Apply this suggestion
Suggestion importance[1-10]: 7
__
Why: The suggestion adds robust error handling for potential timeout issues when waiting for console logs, which would make the test more reliable and provide clearer failure messages. This is particularly important for integration tests involving browser console interactions.
Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Types of changes
Checklist
PR Type
Tests, Bug fix
Description
Removed specific assertions in Ruby DevTools tests for better compatibility.
Marked a Python test as expected to fail in remote environments.
Excluded a problematic Python test from the Firefox test suite in Bazel.
Improved test stability and compatibility across environments.
Changes walkthrough 📝
devtools_spec.rb
Adjust Ruby DevTools test to improve compatibilityrb/spec/integration/selenium/webdriver/devtools_spec.rb
devtools_tests.py
Mark Python test as expected to fail remotelypy/test/selenium/webdriver/common/devtools_tests.py
@pytest.mark.xfail_remoteto mark test as expected to fail inremote environments.
BUILD.bazel
Exclude problematic test from Firefox suite in Bazelpy/BUILD.bazel
devtools_tests.pyfrom the Firefox test suite.