You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
public V85Log(LogAdapter adapter)
{
- this.adapter = adapter;+ this.adapter = adapter ?? throw new ArgumentNullException(nameof(adapter));
this.adapter.EntryAdded += OnAdapterEntryAdded;
Apply this suggestion
Suggestion importance[1-10]: 8
__
Why: Adding null check for constructor parameter is crucial for preventing NullReferenceException and maintaining consistency with other version implementations. This is a significant defensive programming practice.
Medium
General
Make field immutable
Mark the adapter field as readonly since it's only set in the constructor and never modified
Why: Making the field readonly improves code safety by preventing accidental modifications after initialization, though the impact is moderate since the field is already private and only set in constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Annotate nullability on
LogprotocolMotivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement
Description
Enabled nullable reference types in multiple
Logprotocol classes.Added nullability annotations to event handlers and parameters.
Introduced
ArgumentNullExceptionfor constructor parameter validation.Improved code clarity and safety across
Logprotocol implementations.Changes walkthrough 📝
Log.cs
Enable nullable reference types in `Log` base classdotnet/src/webdriver/DevTools/Log.cs
EntryAddedevent with nullable type.V130Log.cs
Add nullability and validation in `V130Log`dotnet/src/webdriver/DevTools/v130/V130Log.cs
ArgumentNullExceptionfor constructor parameter validation.V131Log.cs
Add nullability and validation in `V131Log`dotnet/src/webdriver/DevTools/v131/V131Log.cs
ArgumentNullExceptionfor constructor parameter validation.V132Log.cs
Add nullability and validation in `V132Log`dotnet/src/webdriver/DevTools/v132/V132Log.cs
ArgumentNullExceptionfor constructor parameter validation.V85Log.cs
Add nullability and validation in `V85Log`dotnet/src/webdriver/DevTools/v85/V85Log.cs
ArgumentNullExceptionfor constructor parameter validation.