[java] Remove deprecated non-w3c compliant NetworkConnection interface#15270
Merged
pujagani merged 4 commits intoSeleniumHQ:trunkfrom Feb 11, 2025
Merged
[java] Remove deprecated non-w3c compliant NetworkConnection interface#15270pujagani merged 4 commits intoSeleniumHQ:trunkfrom
pujagani merged 4 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests, Bug fix
Description
Removed deprecated
NetworkConnectioninterface and related implementations.Updated
ChromiumDriverto eliminateNetworkConnectionreferences.Deleted associated tests and configurations for
NetworkConnection.Cleaned up unused commands and dependencies in various files.
Changes walkthrough 📝
5 files
Removed `NetworkConnection` references and methods.Deleted deprecated `NetworkConnection` interface.Removed `NetworkConnection` related commands.Removed `NetworkConnection` command definitions.Deleted deprecated `RemoteNetworkConnection` implementation.1 files
Removed tests for `NetworkConnection`.1 files
Removed `NetworkConnection` related SpotBugs exclusion.2 files
Removed `mobile` package from Bazel build configuration.Deleted Bazel build configuration for `NetworkConnection` tests.