[java]: fix return type and docstring for getDownloadableFiles#15293
Merged
VietND96 merged 2 commits intoSeleniumHQ:trunkfrom Feb 17, 2025
Merged
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
VietND96
approved these changes
Feb 17, 2025
Member
VietND96
left a comment
There was a problem hiding this comment.
Currently, implementation returns as List<String>. So, updating docs to be aligned is fine, no regression break.
8 tasks
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Fixes #15288
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Fixed the return type of
getDownloadableFilesmethod toList<String>.Updated the method's JavaDoc to reflect the corrected return type.
Added a unit test to verify the return type and behavior of
getDownloadableFiles.Ensured proper formatting by running the formatting script.
Changes walkthrough 📝
RemoteWebDriver.java
Corrected JavaDoc for `getDownloadableFiles` methodjava/src/org/openqa/selenium/remote/RemoteWebDriver.java
getDownloadableFilesmethod to correct thedescription.
MaptoList.RemoteWebDriverUnitTest.java
Added unit test for `getDownloadableFiles` methodjava/test/org/openqa/selenium/remote/RemoteWebDriverUnitTest.java
getDownloadableFilesmethod.