You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns
Supply chain integrity: Changes rely on external download URLs. While SHA256 pins are updated, reviewers should confirm they were sourced from official release pages and match the binaries to mitigate tampering risks.
Verify the new SHA256 checksums actually match the downloaded artifacts for the updated Firefox beta and EdgeDriver URLs to avoid build failures or supply-chain issues.
url="https://ftp.mozilla.org/pub/firefox/releases/143.0b3/linux-x86_64/en-US/firefox-143.0b3.tar.xz",
sha256="ea43085f0a47d14a8c088175b489c8af149f59703aec20e6dd2bbf01e36d36fc",
build_file_content="""load("@aspect_rules_js//js:defs.bzl", "js_library")package(default_visibility = ["//visibility:public"])filegroup( name = "files", srcs = glob(["**/*"]),)exports_files(["firefox/firefox"])js_library( name = "firefox-js", data = [":files"],)""",
)
dmg_archive(
name="mac_beta_firefox",
url="https://ftp.mozilla.org/pub/firefox/releases/143.0b3/mac/en-US/Firefox%20143.0b3.dmg",
sha256="0e392fc487de20c31c4fe66e25473f91ce001dd6e56528409720f7b9934f34e0",
build_file_content= """
Pin the archive integrity using strip_prefix or type to ensure the extracted layout is as expected. If Mozilla changes the top-level directory name, builds may silently break. Set strip_prefix to the known folder name within the tarball for this version.
Why: This is a good suggestion for improving build robustness by using strip_prefix to handle potential changes in the archive's directory structure.
Low
General
Validate DMG contents
Add a fail_fast or executable/app_path parameter (if supported by your dmg_archive macro) to validate the expected .app bundle exists after mount. This prevents silent success when the DMG content layout changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This is an automated pull request to update pinned browsers and drivers
Merge after verify the new browser versions properly passing the tests and no bugs need to be filed
PR Type
Other
Description
Update Firefox beta from 143.0b2 to 143.0b3
Update Edge driver from 139.0.3405.102 to 139.0.3405.111
Update SHA256 checksums for all browser binaries
Diagram Walkthrough
File Walkthrough
repositories.bzl
Browser version and checksum updatescommon/repositories.bzl
macOS
Linux and macOS