[build] Pin Browsers in Bazel by default#16743
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
User description
PR Reason
Everything in the CI is already pinning browsers (except remote python tests, where I think it was just an oversight, not intentional). Better to make it the default for bazel, and have users override if they want different behavior.
💥 What does this PR do?
🔧 Implementation Notes
Could have removed this entirely and used a new flag for use_selenium_manager or something, but this is more backwards compatible
💡 Additional Considerations
I can't think of a good reason not to set this at this point.
🔄 Types of changes
PR Type
Enhancement
Description
Changes default
pin_browsersflag from false to trueRemoves explicit
--pin_browsers=truefrom CI workflowsRemoves unused
use_pinned_browserconfig settingUpdates documentation to reflect new default behavior
Diagram Walkthrough
File Walkthrough
BUILD.bazel
Set pin_browsers default to truecommon/BUILD.bazel
pin_browsersbool_flagbuild_setting_defaultfromFalsetoTrueuse_pinned_browserconfig_setting that checked the flagvalue
.bazelrc.remote
Remove redundant remote pin_browsers config.bazelrc.remote
build:rbe --//common:pin_browsersline from remote buildconfiguration
ci-dotnet.yml
Remove explicit pin_browsers flag from dotnet tests.github/workflows/ci-dotnet.yml
--pin_browsers=trueflag from dotnet browser test commandci-java.yml
Remove explicit pin_browsers flags from java tests.github/workflows/ci-java.yml
--pin_browsers=trueflag from three separate test commandsjobs
ci-python.yml
Remove explicit pin_browsers flags from python tests.github/workflows/ci-python.yml
--pin_browsers=trueflag from three Python integration testcommands
ci-ruby.yml
Remove explicit pin_browsers flags from ruby tests.github/workflows/ci-ruby.yml
--pin_browsersflag from two Ruby test commandsREADME.md
Update documentation for new pin_browsers defaultREADME.md
--pin_browsersto--pin_browsers=falseinstead
--pin_browsers=truefrom all dotnet test examples