export element props without [key: string]: any;

[evollu]

Feature Request

Problem description

We use typescript and HOC in our project. There are many cases where we wrap a semantic element and need to remove a property.
For example,

• we have a HOC which wraps Dropdown component and passes option though redux. Then we need to remove option from props
• we introduced a default property but the only clean way to define the typescript is using HOC to change a required prop to be optional

In both cases, we need to utilize Omit (reference) operation to remove a key from Semantic element's prop type definition. However each type definition from Semantic contains [key: string]: any; which makes Omit not working

Proposed solution

export a type definiton without [key: string]: any; for HOC to use.

MVP

Take button as example
Current code:

export interface ButtonProps {
  [key: string]: any;

  /** An element type to render as (string or function). */
  as?: any;

  /** A button can show it is currently the active user selection. */
  active?: boolean;
}

Proposal

export interface ButtonPropsStrict {
  /** An element type to render as (string or function). */
  as?: any;

  /** A button can show it is currently the active user selection. */
  active?: boolean;
}

export interface ButtonProps = ButtonPropsStrict & { [key: string]: any; }

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

[levithomason]

This seems like a great proposal to me. This still meets the goals of our earlier discussion while also giving type safety when needed.

PRs welcome!

[tosman]

The issue with this solution is still has the problems noted in the earlier discussion. It seems to me the best way to support both of these scenarios would be to extend from HTMLProps. Thoughts?

[evollu]

@levithomason I've created a PR for Dropdown. If you a fine with the change, I will apply the change to more components.

[stale]

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!