Skip to content

fix(Button): revert rendering labeled buttons as <button> #612

@levithomason

Description

@levithomason

This should be fixed by fixing #510, not by creating another patch PR. This bug was introduced in #597.

A labeled button has children that can include a <button> element. Therefore, the container element cannot be a button and also have <button> children. This is not valid markup.

http://technologyadvice.github.io/stardust/elements/button#labeled

image

image

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions