fix(Dropdown|Modal|TextArea): update refs handlers#1360
fix(Dropdown|Modal|TextArea): update refs handlers#1360levithomason merged 10 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 140 140
Lines 2345 2346 +1
==========================================
+ Hits 2339 2340 +1
Misses 6 6
Continue to review full report at Codecov.
|
src/addons/TextArea/TextArea.js
Outdated
| this.updateHeight(e.target) | ||
| } | ||
|
|
||
| handleRef = c => (this.rootNode = c) |
There was a problem hiding this comment.
Nice, we should also standardize these ref variable names. We currently use *Node, _* and *Ref in various places.
A ref can either be a node (DOM component) or a reference to a class instance (Composite component). Due to this, I vote we go with this.*Ref for clarity and accuracy.
There was a problem hiding this comment.
Yep, it makes sense 👍
Do I have to change the names to these?
-handleRef = c => (this.rootNode = c)
+handleRef = c => (this.textAreaRef = c)-handleSearchRef = c => (this._search = c)
+handleSearchRef = c => (this.searchRef = c)
|
I've updated the refs per our agreement. Refs at the root I simply used Give it a look over and let me know if we're good to go here. |
|
I've updated |
* fix(Dropdown|Modal|TextArea): update refs handlers * fix(TextArea): update ref names * fix(Form): update ref names * fix(Checkbox): update ref names * fix(Dimmer): update ref names * fix(Dropdown): update ref names * fix(Modal): update ref names * fix(Popup): update ref names * style(Checkbox): update ref handler
|
Released in |
3 participants
Addresses #607.