BREAKING(package): update to React 16 by layershifter · Pull Request #2880 · Semantic-Org/Semantic-UI-React

layershifter · 2018-06-05T14:36:39Z

BREAKING CHANGES

Fixes #2747.
Fixes #2886.
Fixes #2910.

React 16 was released in September 2017, the update process is simple and I don't know any supported application that still uses React 15. It's time to say goodbye to React 15.

Please keep in mind, that in near future we will require React 16.3.

1. Requirement of React 16

Now SUIR requires react^16.0.0.

2. Breaking changes in `Portal`

See #2755 for detailed list of performed changes.

3. Add the `triggerRef` for `Portal`

See #2902 for more details.

4. Breaking changes in the shorthand API of `Accordion`

See #2904 for detailed list of performed changes.

* breaking(Portal): use createPortal() API * test(Portal): rewrite tests * test(Portal): rewrite tests * fix(Portal): mixed fixes in tests * fix(Portal): fix path of typings

…React into react-16

…React into react-16 Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> # Conflicts: # docs/app/Components/IconSearch/IconSearch.js # index.d.ts # src/addons/Portal/Portal.d.ts # src/addons/Portal/Portal.js # src/elements/Flag/Flag.js # src/elements/Icon/Icon.js # src/modules/Modal/Modal.js

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

…React into react-16 Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> # Conflicts: # docs/src/examples/modules/Modal/Variations/ModalExampleCloseConfig.js

* feat(Portal): add `triggerRef` prop Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> * test(Portal): add test for `triggerRef` prop Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

codecov-io · 2018-06-12T08:52:52Z

Codecov Report

❗ No coverage uploaded for pull request base (master@6484449). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2880   +/-   ##
=========================================
  Coverage          ?   99.81%           
=========================================
  Files             ?      163           
  Lines             ?     2738           
  Branches          ?        0           
=========================================
  Hits              ?     2733           
  Misses            ?        5           
  Partials          ?        0

Impacted Files	Coverage Δ
src/elements/Flag/Flag.js	`100% <ø> (ø)`
src/elements/Icon/Icon.js	`100% <ø> (ø)`
src/modules/Accordion/Accordion.js	`100% <100%> (ø)`
src/modules/Popup/Popup.js	`100% <100%> (ø)`
src/addons/Portal/PortalInner.js	`100% <100%> (ø)`
src/modules/Accordion/AccordionPanel.js	`100% <100%> (ø)`
src/addons/Portal/Portal.js	`100% <100%> (ø)`
src/modules/Modal/Modal.js	`100% <100%> (ø)`
src/modules/Accordion/AccordionAccordion.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6484449...89c1b96. Read the comment docs.

) * refactor(Accordion): simplify render with AccordionPanel

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

layershifter · 2018-06-18T07:43:13Z

@levithomason marked as ready for review.

I don't want to include there changes for Breadcrumb because they are very unclear. Changes for forwardRef I want include to future releases.

ivosabev · 2018-06-18T14:35:20Z

When is this scheduled to ship?

layershifter · 2018-06-18T14:46:22Z

I hope on this or next week.

…React into react-16 Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> # Conflicts: # index.d.ts # src/addons/Portal/Portal.d.ts # src/elements/Flag/Flag.d.ts # src/elements/Icon/Icon.d.ts # src/modules/Accordion/AccordionAccordion.d.ts

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

layershifter · 2018-06-25T10:06:03Z

Merged with masted and solved merge conflicts.

levithomason · 2018-06-26T02:33:09Z

We have two failing tests here, I've run out of time for today:

Dropdown
     onOpen
      ✖ is called once when the icon is clicked with a search prop
     search
      ✖ filters the items based on custom search function

mgandley · 2018-06-26T20:57:53Z

Waiting on this for the IE portal fix! Thanks for your work on it @layershifter!

…React into react-16 Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> # Conflicts: # src/modules/Popup/Popup.js

…I-React into react-16

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

layershifter · 2018-06-27T15:38:02Z

We have two failing tests here, I've run out of time for today:

@levithomason I hate the Dropdown component, I will refactor it fully someday

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

layershifter · 2018-06-27T15:59:58Z

I reverted updates in yarn.lock, tests are passed. It seems that we will have the surprise from minor updates in dependencies.

layershifter · 2018-06-27T16:07:59Z

@levithomason I want to merge and release any solution for #2958 before this.

levithomason · 2018-06-27T22:37:46Z

@layershifter I've merged #2958 released semantic-ui-react@0.81.3. I'm good with this PR if and when you are. Feel free to merge after fixing conflicts and I'll release as 0.82.0.

…React into react-16 # Conflicts: # src/addons/Portal/Portal.d.ts # src/addons/Portal/Portal.js

layershifter · 2018-06-29T07:04:45Z

Solved merged conflicts and merged 👍

levithomason · 2018-07-06T06:40:35Z

Released in semantic-ui-react@0.82.0.

layershifter added 3 commits May 13, 2018 16:14

breaking(Portal): use createPortal() API (#2755)

c33a720

* breaking(Portal): use createPortal() API * test(Portal): rewrite tests * test(Portal): rewrite tests * fix(Portal): mixed fixes in tests * fix(Portal): fix path of typings

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

88c94d4

…React into react-16

feat(Flag|Icon): use PureComponent instead of shallowEqual() (#2842)

762618a

layershifter changed the title ~~breaking(package): Update to React 16~~ BREAKING(package): Update to React 16 Jun 5, 2018

layershifter changed the title ~~BREAKING(package): Update to React 16~~ BREAKING(package): update to React 16 Jun 5, 2018

layershifter added the chore label Jun 6, 2018

Oleksandr Fediashov added 5 commits June 6, 2018 13:26

fix(IconSearch): remove prop

8cf6884

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

fix(PortalInner): remove meta

ae7f413

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

fix(Portal): fix broken test

1d46672

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

fix(Modal): go away from rootNode

a895a28

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

fix(Flag|Icon): remove unused import

1db2802

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

This was referenced Jun 6, 2018

Portal: recent change breaks in IE11 #2886

Closed

Modal: add dimmer shorthand #2877

Closed

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

1b9ed77

…React into react-16 Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> # Conflicts: # docs/src/examples/modules/Modal/Variations/ModalExampleCloseConfig.js

layershifter mentioned this pull request Jun 12, 2018

feat(Portal): add triggerRef prop #2902

Merged

layershifter and others added 2 commits June 12, 2018 10:59

feat(Portal): add triggerRef prop (#2902)

f6e4d8f

* feat(Portal): add `triggerRef` prop Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> * test(Portal): add test for `triggerRef` prop Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

fix(Popup): fix test

738e8db

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

This was referenced Jun 12, 2018

BREAKING(Accordion): refactor shorthand API to use AccordionPanel #2904

Merged

<Portal/> and new context API #2910

Closed

layershifter and others added 4 commits June 15, 2018 12:53

BREAKING(Accordion): refactor shorthand API to use AccordionPanel (#2904

492cd90

) * refactor(Accordion): simplify render with AccordionPanel

Merge branch 'master' into react-16

795f8be

style(Accordion): add description

fd2cb59

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

fix(tests): reenable throw on console.log()

f039af3

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

layershifter added the ready for review label Jun 18, 2018

layershifter requested a review from levithomason June 18, 2018 07:38

Oleksandr Fediashov added 2 commits June 25, 2018 12:47

style(mixed): lint issues in typings

cf5f86f

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

layershifter mentioned this pull request Jun 25, 2018

[WIP] - Portal component experiment stardust-ui/react-old#37

Open

merge master

88a18c1

levithomason added the ready for merge label Jun 26, 2018

levithomason added 2 commits June 25, 2018 18:52

fix yarn.lock

08f6c15

fix(ComponentDocLinks): add rel="noopener noreferrer"

68cbdd0

levithomason removed the ready for merge label Jun 26, 2018

mgandley mentioned this pull request Jun 26, 2018

Modal hard fails in IE 11 #2952

Closed

Oleksandr Fediashov added 3 commits June 27, 2018 15:43

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

051ca32

…React into react-16 Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com> # Conflicts: # src/modules/Popup/Popup.js

Merge branch 'react-16' of https://github.com/Semantic-Org/Semantic-U…

2b4e22f

…I-React into react-16

revert styling changes

dbe6e78

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

Oleksandr Fediashov and others added 2 commits June 27, 2018 18:48

restore yarn.lock from master

671e923

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

Merge branch 'master' into react-16

e2361e6

layershifter added 2 commits June 29, 2018 09:54

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

2cf45b3

…React into react-16 # Conflicts: # src/addons/Portal/Portal.d.ts # src/addons/Portal/Portal.js

style(Portal): remove render method

89c1b96

layershifter merged commit 1d795bc into master Jun 29, 2018

nazar mentioned this pull request Jul 2, 2018

Quick edit game player character mikelax/forgingadventures#169

Merged

layershifter deleted the react-16 branch July 20, 2018 13:23

levithomason added the breaking-change label Dec 10, 2018

layershifter mentioned this pull request Mar 18, 2019

Dropdown: child's onclick firing dropdown's onclick #3517

Closed

Conversation

layershifter commented Jun 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BREAKING CHANGES

1. Requirement of React 16

2. Breaking changes in Portal

3. Add the triggerRef for Portal

4. Breaking changes in the shorthand API of Accordion

Uh oh!

codecov-io commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

layershifter commented Jun 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivosabev commented Jun 18, 2018

Uh oh!

layershifter commented Jun 18, 2018

Uh oh!

layershifter commented Jun 25, 2018

Uh oh!

levithomason commented Jun 26, 2018

Uh oh!

mgandley commented Jun 26, 2018

Uh oh!

layershifter commented Jun 27, 2018

Uh oh!

layershifter commented Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

layershifter commented Jun 27, 2018

Uh oh!

levithomason commented Jun 27, 2018

Uh oh!

layershifter commented Jun 29, 2018

Uh oh!

levithomason commented Jul 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

layershifter commented Jun 5, 2018 •

edited

Loading

2. Breaking changes in `Portal`

3. Add the `triggerRef` for `Portal`

4. Breaking changes in the shorthand API of `Accordion`

codecov-io commented Jun 12, 2018 •

edited

Loading

layershifter commented Jun 18, 2018 •

edited

Loading

layershifter commented Jun 27, 2018 •

edited

Loading