Merged
Conversation
levithomason
force-pushed
the
feature/remove-sd-classes
branch
from
b375feb to
617e481
Compare
Current coverage is 88.03%
|
| children.forEach(c => { | ||
| const childClassName = c.prop('className') | ||
| if (childClassName) childClassName.should.not.contain('sd-') | ||
| }) |
Member
Author
There was a problem hiding this comment.
I've inverted this test for now to help catch any further sd-* classes from other PRs that have not yet been scrubbed. After a while, we can remove this test.
This was referenced Jun 28, 2016
jhchill666
pushed a commit
to jhchill666/stardust
that referenced
this pull request
Jul 5, 2016
* test(common): fail if sd-* className exists * refactor(className): remove sd-* classNames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293. This PR removes all
sd-*classNames. This was done as we are now officially a SUI project. There will be no more "Stardust" once migrated.The test ensuring the
sd-*class exists has been inverted to ensure it does not exist. This is only until we are done merging other PRs which are still using thesd-*class.