fix(typings): fix definition for SemanticShorthandItemFunc#3204
Merged
layershifter merged 2 commits intomasterfrom Oct 9, 2018
Merged
fix(typings): fix definition for SemanticShorthandItemFunc#3204layershifter merged 2 commits intomasterfrom
layershifter merged 2 commits intomasterfrom
Conversation
added 2 commits
October 9, 2018 15:57
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
…React into fix/shorthand-typings
Codecov Report
@@ Coverage Diff @@
## master #3204 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 169 169
Lines 2790 2790
=======================================
Hits 2788 2788
Misses 2 2Continue to review full report at Codecov.
|
Member
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Levi mentioned in microsoft/fluent-ui-react#328 (comment), typings should be correct. This stuff wasn't released yet, so there are no breaking changes.