fix(AutoControlledComponent): fix behaviour when undefined it passed#3303
Merged
layershifter merged 1 commit intomasterfrom Nov 25, 2018
Merged
fix(AutoControlledComponent): fix behaviour when undefined it passed#3303layershifter merged 1 commit intomasterfrom
layershifter merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3303 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 169 169
Lines 2803 2803
=======================================
Hits 2801 2801
Misses 2 2Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports changes from microsoft/fluent-ui-react#499
We discussed this changes during meetings on the previous week, we need to change the behaviour of
AutoControlledComponentto match React's.An example that shows issue: https://codesandbox.io/s/l20mjn74zz
After this PR we can safely migrate to
getDerivedStateFromProps()👍