LibJS: Add %TypedArray%.prototype.toSorted#14400
Merged
linusg merged 3 commits intoSerenityOS:masterfrom Jun 29, 2022
Merged
Conversation
Member
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
beesaferoot
force-pushed
the
typed-array-update
branch
6 times, most recently
from
37f4556 to
9986ce4
Compare
linusg
reviewed
Jun 27, 2022
beesaferoot
force-pushed
the
typed-array-update
branch
2 times, most recently
from
983a5bc to
4f51fd4
Compare
linusg
suggested changes
Jun 29, 2022
Member
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
Great work, couple of nitpicks :)
The third function should be named something like LibJS: Add tests cases for %TypedArray%.prototype.toSorted, just toSorted is ambiguous.
beesaferoot
force-pushed
the
typed-array-update
branch
from
76cece9 to
7a53b20
Compare
linusg
reviewed
Jun 29, 2022
Member
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
Small thing I missed earlier: %TypedArray% instead of TypedArray for the second commit, like in the PR title :)
beesaferoot
force-pushed
the
typed-array-update
branch
from
7a53b20 to
50799dc
Compare
This change implements typed array prototype toSorted function. It also introduces two new TypedArray functions
beesaferoot
force-pushed
the
typed-array-update
branch
from
50799dc to
5792f6d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To implement toSorted, this change introduces 2 new TypedArray functions (typed_array_create_same_type, compare_typed_array_elements)