LibJS: Add %TypedArray%.prototype.toReversed #14445
Merged
linusg merged 2 commits intoSerenityOS:masterfrom Jul 2, 2022
Merged
LibJS: Add %TypedArray%.prototype.toReversed #14445linusg merged 2 commits intoSerenityOS:masterfrom
linusg merged 2 commits intoSerenityOS:masterfrom
Conversation
linusg
reviewed
Jun 30, 2022
Member
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
Nice, mostly LGTM! First commit contains the tests that should probably go into the second :)
beesaferoot
force-pushed
the
typed-array-update
branch
from
5535af6 to
f18fa9d
Compare
linusg
reviewed
Jun 30, 2022
beesaferoot
force-pushed
the
typed-array-update
branch
2 times, most recently
from
0f6dd38 to
dc8a5ea
Compare
linusg
reviewed
Jul 2, 2022
| // 6. Repeat, while k < length | ||
| for (size_t k = 0; k < length; k++) { | ||
| // a. Let from be ! ToString(𝔽(length - k - 1)). | ||
| // Let Pk be ! ToString(𝔽(k)). |
beesaferoot
force-pushed
the
typed-array-update
branch
from
dc8a5ea to
dee66f3
Compare
linusg
force-pushed
the
typed-array-update
branch
from
dee66f3 to
c5812e4
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.