Fix unexpected borders in Performance Analysis table#118
Merged
JosephMarinier merged 3 commits intomainfrom Jun 6, 2022
Merged
Fix unexpected borders in Performance Analysis table#118JosephMarinier merged 3 commits intomainfrom
JosephMarinier merged 3 commits intomainfrom
Conversation
as `Table sx={{...}}` was overwriting the `sx` defined inside `Table`.
christyler3030
approved these changes
Jun 6, 2022
gabegma
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Fix unexpected borders in Table as `Table sx={{...}}` was overwriting the `sx` defined inside `Table`.
* Clean up
- Select only classes below `&` prevent styling from "bleeding" out of the component and into other components with the same class names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #90
Table sx={{...}}was overwriting thesxdefined insideTable.&prevent styling from "bleeding" out of the component and into other components with the same class names.Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.