Add the ability to disable post-processing for filterable modules#58
Add the ability to disable post-processing for filterable modules#58
Conversation
gabegma
force-pushed
the
ggm/disabling-post-processing
branch
from
c3ab905 to
a14790d
Compare
There was a problem hiding this comment.
LGTM! This touches a lot of code that I'm not super familiar with, so if you have any uncertainty it might be worth validating with @Dref360, but otherwise I think it makes sense and it's great functionality!
|
Maybe we should add something to the changelog for this? |
Co-authored-by: Lindsay Brin <lindsay.brin@gmail.com>
…/azimuth into ggm/disabling-post-processing
Dref360
left a comment
Dref360
left a comment
There was a problem hiding this comment.
LGTM, some minor comments
|
@Dref360 can you review my latest commit (not the merge) since I made a few additional changes? |
| dataset_split_manager: DatasetSplitManager = Depends(get_dataset_split_manager), | ||
| pipeline_index: Optional[int] = Depends(query_pipeline_index), | ||
| pagination: Optional[PaginationParams] = Depends(get_pagination), | ||
| without_postprocessing: bool = False, |
There was a problem hiding this comment.
Sorry, I am late to the party, I didn't realize that was getting merged.
Everywhere this query parameter is defined, it should have an alias to make it camelCase, like the others, for example smartTags, dataActions, or confidenceMin/Max).
@nandhinibsn, could you add those in your PR?
| without_postprocessing: bool = False, | |
| without_postprocessing: bool = Query( | |
| False, title="Without Postprocessing", alias="withoutPostprocessing" | |
| ), |
There was a problem hiding this comment.
I agree. I can add those alias on the UI.
There was a problem hiding this comment.
Oh so sorry, thanks! I should have tagged you in that PR.
There was a problem hiding this comment.
No-no-no, no need to be sorry. One step at a time. 👍
5 participants
Description:
Add a module option to disable post-processing for all filterable modules. This will allow a new toggle in the control panel to see metrics/top words/confusion matrix/histogram without post-processing.
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.