Add options for non-normalized confusion matrix#65
Merged
Conversation
gabegma
approved these changes
May 10, 2022
Contributor
gabegma
left a comment
There was a problem hiding this comment.
LGTM! Tiny comment about naming.
| 20, | ||
| title="Nb of bins to compute for different modules.", | ||
| ) | ||
| normalized: bool = Field(True, title="Normalize the confusion matrix.") |
Contributor
There was a problem hiding this comment.
I find it odd that confusion matrix is not mentioned in the option name. Did you have in mind that it could be useful for other modules?
Contributor
Author
There was a problem hiding this comment.
like cf_normalized?
Contributor
There was a problem hiding this comment.
Sold! FYI - I don't mind for the route that it's called only normalized - it's only in module options where it is mixed with everything else that I find it confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add options for non-normalized confusion matrix
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.