Skip to content

Add profiling code and caching for metrics#69

Merged
Dref360 merged 1 commit intodevfrom
features/profiling
May 16, 2022
Merged

Add profiling code and caching for metrics#69
Dref360 merged 1 commit intodevfrom
features/profiling

Conversation

@Dref360
Copy link
Contributor

@Dref360 Dref360 commented May 13, 2022

Description:

Add code to profile different Modules. Work similarly as startup tasks, but run our profiling tool.

By doing so, I was able to find that loading metrics would cause a large bottleneck. So I added them to the artifact manager.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@Dref360 Dref360 requested a review from gabegma May 13, 2022 17:37
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I love it!

@Dref360 Dref360 merged commit acc9c66 into dev May 16, 2022
@Dref360 Dref360 deleted the features/profiling branch May 16, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants