Use launch instead of compose to get image from DockerHub#85
Merged
Conversation
gabegma
reviewed
Jun 1, 2022
Contributor
gabegma
left a comment
There was a problem hiding this comment.
So the image gets updated everytime we merge on main? Do they still need to git clone our repo?
Contributor
Author
|
Every time we make a new tag. What I see in the future is:
Then our users can quickly get Azimuth running on their usecase. |
gabegma
approved these changes
Jun 1, 2022
Contributor
gabegma
left a comment
There was a problem hiding this comment.
LGTM! Just missing in the README to change from compose to launch!
Contributor
Author
|
Will merge once all the images are pushed (probably by eod) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Our users can now take images from DockerHub instead of building manually.
This PR tries to automate the process.
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.