Skip to content

Update Default Gains to Align with AMDS Sensor Card Documentation#496

Merged
elsevers merged 1 commit intodevelopfrom
fix/update-amds-gains
Nov 21, 2025
Merged

Update Default Gains to Align with AMDS Sensor Card Documentation#496
elsevers merged 1 commit intodevelopfrom
fix/update-amds-gains

Conversation

@mohamed-dek1
Copy link

@mohamed-dek1 mohamed-dek1 commented Nov 21, 2025

Closes #497

Notes

Anything reviewers should be aware of when reviewing? Other related issues? Known problems? Future work?

Self-Review

  1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? N/A
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? N/A
  3. Do all Markdown files follow the CONTRIBUTING article template? N/A
  4. Do all links work in the material that the PR is adding? N/A
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@Daehoon-Sung, can you review this?

@elsevers
Copy link
Contributor

Thanks @mohamed-dek1. Can you create an issue that this closes? This is important for how we track releases.

@mohamed-dek1
Copy link
Author

@elsevers, I've made an issue for this PR.

@mohamed-dek1 mohamed-dek1 changed the title Updates Default Gains to Align with AMDS Sensor Card Documentation Update Default Gains to Align with AMDS Sensor Card Documentation Nov 21, 2025
@elsevers elsevers linked an issue Nov 21, 2025 that may be closed by this pull request
Copy link
Contributor

@elsevers elsevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mohamed-dek1.

I have scheduled this on the release planner board to be a v1.4.2 release.

@elsevers elsevers merged commit 787fdca into develop Nov 21, 2025
1 check passed
@elsevers elsevers deleted the fix/update-amds-gains branch November 21, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the default gains to match new AMDS documentation

2 participants