Skip to content

feat: partial check in & scan to check in:#1952

Merged
DonKoko merged 51 commits intomainfrom
1950-feat-scan-to-checking-partial-check-ins
Aug 13, 2025
Merged

feat: partial check in & scan to check in:#1952
DonKoko merged 51 commits intomainfrom
1950-feat-scan-to-checking-partial-check-ins

Conversation

@DonKoko
Copy link
Copy Markdown
Contributor

@DonKoko DonKoko commented Jul 25, 2025

No description provided.

@DonKoko DonKoko linked an issue Jul 25, 2025 that may be closed by this pull request
@DonKoko DonKoko requested a review from Copilot July 25, 2025 17:19
@vercel
Copy link
Copy Markdown

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
shelf-docs ⬜️ Ignored Preview Aug 13, 2025 9:35am

This comment was marked as outdated.

@DonKoko
Copy link
Copy Markdown
Contributor Author

DonKoko commented Jul 29, 2025

  • I managed to check out an asset in 2 bookings
  • have a ongoing booking
  • create a second ongoing booking.
  • Use scan to add an asset from the first booking to the second ongoing booking
  • Assets that are checked out are showing labels when they shouldn't
  • Availability checks should still be implemented for kits the same way we did for assets with the new 2 rule system. Now if a kit has been checked in with partial, in a conflicting booking it will still show as already booked and it shouldn't as its available
  • Should update the booking assets preview sheet to show better information about asset including some AvailabilityLabels
  • ! Validations that block "Reserve" and "Check out" button in case of conflicts have to also be done server side as now they can be skipped with some trickery

DonKoko added 3 commits July 29, 2025 18:47
…handle all availability logic due to complications with partial check-ins
@carlosvirreira
Copy link
Copy Markdown
Contributor

so epic you keep pushing here bro, thanks!

@DonKoko DonKoko requested a review from Copilot August 5, 2025 12:12

This comment was marked as outdated.

DonKoko added 25 commits August 7, 2025 16:39
…k assets or kits by going around some limitations
…ls are shown for partially checked in assets
…justing blockers in partial-checkin-drawer to consider the context status
@DonKoko DonKoko requested a review from Copilot August 13, 2025 09:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive partial check-in feature for bookings, allowing users to scan QR codes to incrementally check in assets while maintaining proper state management and conflict resolution. The implementation includes centralized business logic, enhanced UI components, and administrative update management features.

Key Changes

  • Partial Check-in System: Added scanning interface and progress tracking for individual asset check-ins within bookings
  • Centralized Booking Conflict Logic: Unified business rules for asset/kit availability across all booking operations
  • Administrative Update Management: New system for admins to create and manage user-facing updates with role-based targeting

Reviewed Changes

Copilot reviewed 75 out of 76 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Added @radix-ui/react-progress dependency for progress indicators
docs/booking-conflict-queries.md Comprehensive documentation of booking conflict patterns and business rules
app/utils/booking-assets.ts Centralized utilities for context-aware asset/kit status resolution
app/routes/_layout+/bookings.$bookingId.tsx Enhanced booking page with partial check-in support and progress tracking
app/routes/_layout+/bookings.$bookingId.checkin-assets.tsx New QR scanner interface for partial asset check-ins
app/modules/booking/service.server.ts Core partial check-in logic and enhanced conflict validation
app/modules/update/service.server.ts Complete user update management system with role targeting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread app/modules/booking/service.server.ts Outdated
Comment thread app/routes/_layout+/bookings.$bookingId.manage-kits.tsx
Comment thread app/routes/_layout+/bookings.$bookingId.tsx
DonKoko and others added 2 commits August 13, 2025 11:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DonKoko DonKoko merged commit 2c4533e into main Aug 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: Scan to checking + Partial check-ins

3 participants