refactor: remove redundant custody extraInclude in kit loader#2028
Merged
refactor: remove redundant custody extraInclude in kit loader#2028
Conversation
The custody field was being selected in both GET_KIT_STATIC_INCLUDES and extraInclude, causing redundancy. Removed the extra custody select since GET_KIT_STATIC_INCLUDES already provides all necessary custody fields including createdAt.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant custody field selection in the kit loader to fix a bug where createdAt was missing from the custody data. The custody field was being selected in both GET_KIT_STATIC_INCLUDES and extraInclude, causing duplication and incomplete data selection.
Key Changes
- Removed duplicate custody selection from
extraIncludeparameter ingetKitcall - Simplified the loader by relying on
GET_KIT_STATIC_INCLUDESfor all custody data - Fixed bug #2024 where
createdAtfield was missing from custody data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custody field was being selected in both
GET_KIT_STATIC_INCLUDESandextraInclude, causing redundancy. Removed the extra custody select sinceGET_KIT_STATIC_INCLUDESalready provides all necessary custody fields includingcreatedAt.Moreover this resolves #2024 as the extra include was not selecting
createdAtso that was causing a bug.