Skip to content

Add location overview tab and valuation aggregation#2042

Merged
DonKoko merged 3 commits intomainfrom
codex/add-overview-tab-to-locations
Sep 18, 2025
Merged

Add location overview tab and valuation aggregation#2042
DonKoko merged 3 commits intomainfrom
codex/add-overview-tab-to-locations

Conversation

@carlosvirreira
Copy link
Copy Markdown
Contributor

Summary

  • add a location overview route that loads formatted metadata and renders an overview card with ID, created date, and total asset value
  • compute location total valuation via a dedicated service helper with unit coverage
  • expose the Overview tab alongside existing Assets and Kits tabs on the location page and add route/component tests

Testing

  • npm run test -- --run

https://chatgpt.com/codex/tasks/task_b_68ca7b4d6b0c8326b7a17286b05223db

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
shelf-docs Ignored Ignored Preview Sep 18, 2025 10:01am

DonKoko and others added 2 commits September 18, 2025 12:03
- Add address and description fields to location overview page
- Use DateS component for proper date formatting instead of raw string
- Reorder location tabs to show overview first, then assets and kits
- Move route test from app/routes to test/routes-tests directory to avoid Remix conflicts
- Update vitest config to include route component tests while excluding e2e tests
- Fix test TypeScript issues with proper mocking of client-hints functions
- Format AGENTS.md with consistent spacing and sections
- Fix booking assets column tooltip text formatting

Test changes:
- Fixed import paths for route test file
- Added missing mock functions (useHints, getDateTimeFormatFromHints)
- Simplified mock data structures with proper type casting
- All tests now pass (2/2) with proper loader and component coverage
@DonKoko DonKoko merged commit 29852de into main Sep 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants