Chore: Add deep type safety for getUserByID with custom ESLint rule #2084
Merged
Chore: Add deep type safety for getUserByID with custom ESLint rule #2084
Conversation
## Problem TypeScript's generic constraints don't validate nested Prisma select fields. This allowed invalid field names in nested relations to pass type checking, causing runtime errors. ## Solution 1. Created custom ESLint rule to enforce 'satisfies Prisma.UserSelect' on getUserByID calls with nested selects 2. Added satisfies annotations to all getUserByID calls with nested relations 3. Fixed existing select clauses missing required fields ## Changes - Add eslint-plugin-local-rules package - Create custom ESLint rule: require-satisfies-on-nested-prisma-selects - Update getUserByID documentation with deep validation examples - Add satisfies to getUserByID calls in: - _layout.tsx - admin-dashboard/$userId.tsx - onboarding.tsx - generate-sequential-ids.tsx - subscription.server.ts - Fix onboarding.tsx: add missing userOrganizations and businessIntel fields - Add defensive null check for user.roles in transfer-ownership-card.tsx - Update test expectations for assign-custody (select instead of include) The ESLint rule only triggers for calls with nested selects, providing automatic type validation without requiring extra work from developers.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
🔥🔥🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TypeScript's generic constraints don't validate nested Prisma select fields.
This allowed invalid field names in nested relations to pass type checking,
causing runtime errors.
Solution
getUserByID calls with nested selects
Changes
The ESLint rule only triggers for calls with nested selects, providing
automatic type validation without requiring extra work from developers.