Handle command palette links for registered and NRM members#2086
Merged
Handle command palette links for registered and NRM members#2086
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
DonKoko
previously approved these changes
Oct 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the command palette's team member navigation by differentiating between registered users and Non-Registered Members (NRMs). The changes enable proper routing based on user type: registered users are directed to their user settings page while NRMs are routed to their edit modal.
Key changes:
- Added
userIdfield to team member search results to identify registered vs. NRM users - Implemented routing logic that directs registered users to
/settings/team/users/:userIdand NRMs to/settings/team/nrm/:id/edit - Added comprehensive test coverage for the new navigation logic including fallback scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/routes/api+/command-palette.search.ts | Added userId field to team member search results |
| app/components/layout/command-palette/command-palette.tsx | Added getTeamMemberHref function and updated navigation logic |
| app/components/layout/command-palette/command-palette.test.tsx | Added tests for the new routing function covering registered users, NRMs, and fallbacks |
DonKoko
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/settings/team/users/:userIdand NRMs to their edit modal, with safe fallbacksTesting
https://chatgpt.com/codex/tasks/task_b_68de78fd7b348326983efa7f0337e497