fix: resolve Chrome date parsing error in location overview#2132
Merged
fix: resolve Chrome date parsing error in location overview#2132
Conversation
Removed server-side date formatting that was causing Chrome to throw "Invalid time value" error. The DateS component now receives the raw Date object and handles all formatting client-side with proper timezone support. The issue was double formatting: server formatted createdAt to a string like "21/11/2024, 13:57", then DateS tried to parse it again, which Chrome's stricter Date parser rejected.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Updated test expectations to reflect that dates are no longer formatted server-side. The loader now returns the raw Date (serialized as ISO string by Remix), and the DateS component handles formatting client-side. Changes: - Removed expectations for getDateTimeFormat mock calls - Updated createdAt assertion to expect ISO string format - Added comments explaining the date serialization behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed server-side date formatting that was causing Chrome to throw "Invalid time value" error. The DateS component now receives the raw Date object and handles all formatting client-side with proper timezone support.
The issue was double formatting: server formatted createdAt to a string like "21/11/2024, 13:57", then DateS tried to parse it again, which Chrome's stricter Date parser rejected.