feat: refresh signup welcome and plan selection flow#2136
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Synchronize testing documentation from CLAUDE.md to AGENTS.md to ensure comprehensive testing guidance for AI agents. Key improvements include: - Add detailed Testing Approach section with Vitest and validation pipeline - Expand Test Philosophy to explicitly discourage testing implementation details - Clarify When to Mock with specific guidance on avoiding internal logic mocks - Improve directory structure examples and factory usage patterns - Enhance Pre-Commit Checklist with focus on behavior-driven tests This ensures agents have complete testing context when working on the codebase and aligns with the project's emphasis on behavior-focused, minimally-mocked tests.
Replace hardcoded plan copy with dynamic generation from Stripe price data. The previous implementation used static values ($67/mo, $37/mo) which would not reflect actual Stripe pricing changes. Changes: - Add getPlanCopy function to dynamically format prices from Stripe data - Extract unit_amount and currency from price objects - Calculate monthly equivalent for annual plans (divide by 10) - Generate dynamic footnotes with actual annual totals - Update iteration to use planPrices instead of hardcoded planCopy object This ensures pricing stays in sync with Stripe configuration and supports currency changes without code modifications.
|
hey @DonKoko works nice - thank you for your latest polish on top of all. Please check that we write 7-day trial as this is our current default. For the rest I find this to be a nice enhancement to what we have. Only thing I noticed that might be - unrelated is that when i clicked on the trial I got an error of not being able to create more workspaces. So - ideally this is something we check if it wont translate to prod.
|
|
@carlosvirreira the days of trial is a env variable because its used in many places in the app. The value we have on staging is just an old value. The original PR actually had it hardcoded which was an issue so I had to fix them. I hope i didn't miss any instances. |
sounds good - besides those points nothing from my end to adjust |
2 participants
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_68f7bb3dc5ac832683f243af3aab07b5