Conversation
…eleting a booking
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the scheduler cancellation was not being called when deleting or cancelling bookings that were not in OVERDUE or ONGOING status. The fix ensures that all bookings with active scheduler references have their schedulers properly cancelled, regardless of booking status.
Key changes:
- Modified
cancelSchedulerto require non-null booking parameter and log errors when scheduler reference is missing - Updated
deleteBookingto fetch and cancel schedulers for all bookings, not just OVERDUE/ONGOING ones - Fixed
bulkDeleteBookingsandbulkCancelBookingsto cancel schedulers for all bookings with references, not just active ones
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.