fix: client-side filter cookie paths and clear functionality#2229
Merged
fix: client-side filter cookie paths and clear functionality#2229
Conversation
Fixed client-side cookie management to work correctly with RR7 single fetch by ensuring consistent root path usage and proper cookie removal. Root cause: Client-side code was still using page-specific paths (/assets, /bookings, /kits) when writing/removing cookies, while server-side was updated to use root path (/). This caused cookies to be recreated at old paths, breaking filter persistence and clear functionality. Changes: - Updated destroyCookieValues to always use root path (/) for consistency - Updated useCookieDestroy hook to use root path instead of determining path from current route - Fixed cookie removal to include same options (sameSite, secure) as cookie setting, as required by js-cookie library - Added legacy cookie cleanup when removing cookies to ensure old path-specific cookies are deleted - Fixed deleteKeysInSearchParams to batch all key deletions in a single setSearchParams call instead of multiple calls that triggered intermediate cookie states This ensures: - Filter cookies work during client-side navigation in RR7 single fetch - Clear filters functionality works correctly in both simple and advanced modes - No stale cookies remain at old paths - Cookie updates are atomic (all-or-nothing) rather than incremental
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed client-side cookie management to work correctly with RR7 single fetch by ensuring consistent root path usage and proper cookie removal.
Root cause: Client-side code was still using page-specific paths (/assets, /bookings, /kits) when writing/removing cookies, while server-side was updated to use root path (/). This caused cookies to be recreated at old paths, breaking filter persistence and clear functionality.
Changes:
This ensures: