perf: cache selected organization per request#2267
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes database query performance by caching getSelectedOrganisation results per request, reducing redundant queries when parallel loaders call requirePermission.
Changes:
- Added per-request caching using WeakMap to store organization lookup promises
- Refactored the original function into
getSelectedOrganisationUncachedas the implementation - Created a new wrapper
getSelectedOrganisationthat implements promise-based caching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request-scoped caching for selected organization (AsyncLocalStorage)
What changed
getSelectedOrganisationnow uses the request cache to reuse the same in-flight promise per user.Why
Request, so Request-keyed caches don’t hit.userOrganization.findManycalls within the same HTTP request, which amplified Prisma connection pool pressure.Impact
userOrganization.findManyper request/user, even when multiple loaders fire.Notes
hasPermissionfallback query is unchanged and remains a defensive edge case.