Concatenate strings directly instead of using fmt#46
Merged
SherClockHolmes merged 2 commits intoSherClockHolmes:masterfrom Jan 1, 2025
Merged
Concatenate strings directly instead of using fmt#46SherClockHolmes merged 2 commits intoSherClockHolmes:masterfrom
SherClockHolmes merged 2 commits intoSherClockHolmes:masterfrom
Conversation
This reduces unnecessary allocations
SherClockHolmes
approved these changes
Oct 3, 2023
slingamn
added a commit
to ergochat/webpush-go
that referenced
this pull request
Dec 29, 2024
slingamn
added a commit
to ergochat/webpush-go
that referenced
this pull request
Dec 31, 2024
This was referenced Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a micro-optimization, but we are running this code in a tight loop and this saves 5 unnecessary allocations.