-
Notifications
You must be signed in to change notification settings - Fork 225
Add addToGitIgnore to cli-kit to append entries to existing .gitignore files
#5239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success2005 tests passing in 905 suites. Report generated by 🧪jest coverage report action from ab407f3 |
frandiox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
28635d5 to
6f3e0fb
Compare
6f3e0fb to
ab407f3
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/git.d.ts@@ -27,6 +27,16 @@ export interface GitIgnoreTemplate {
* @param template - The template to use to create the .gitignore file.
*/
export declare function createGitIgnore(directory: string, template: GitIgnoreTemplate): void;
+/**
+ * Add an entry to an existing .gitignore file.
+ *
+ * If the .gitignore file doesn't exist, or if the entry is already present,
+ * no changes will be made.
+ *
+ * @param root - The directory containing the .gitignore file.
+ * @param entry - The entry to add to the .gitignore file.
+ */
+export declare function addToGitIgnore(root: string, entry: string): void;
/**
* Options to use when cloning a git repository.
*
|
WHY are these changes introduced?
This PR moves the
addToGitIgnoretocli-kit, following the suggestion in this thread #5184 (comment)WHAT is this pull request doing?
This PR moves the
addToGitIgnorefrom thethemepackage tocli-kit, following the suggestion in the thread above.How to test your changes?
shopify theme metafields pull.shopifyis also added in the gitignorePost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist