Skip to content

fix(scroll): read initialScrollIndex offset after layout recompute #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naqvitalha merged 2 commits into from
Mar 4, 2026
Merged

fix(scroll): read initialScrollIndex offset after layout recompute #2133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7acb56a
fix(scroll): read initialScrollIndex offset after layout recompute
naqvitalha Mar 3, 2026
9c199f6
Remove OverlapRepro sample screen
naqvitalha Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions src/recyclerview/RecyclerViewManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,27 +382,26 @@ export class RecyclerViewManager<T> {
}

const initialScrollIndex = this.getInitialScrollIndex();
const initialItemLayout = this.layoutManager?.getLayout(
initialScrollIndex ?? 0
);
const initialItemOffset = this.propsRef.horizontal
? initialItemLayout?.x
: initialItemLayout?.y;

if (initialScrollIndex !== undefined) {
// console.log(
// "initialItemOffset",
// initialScrollIndex,
// initialItemOffset,
// this.firstItemOffset
// );
// Recompute layouts first, then read the offset. The recompute may
// re-estimate unmeasured items with an updated average height, changing
// the target item's position. Reading before recompute would capture a
// stale offset, causing the wrong items to be rendered.
this.layoutManager.recomputeLayouts(0, initialScrollIndex);
this.engagedIndicesTracker.scrollOffset =
initialItemOffset ?? 0 + this.firstItemOffset;
const initialItemLayout =
this.layoutManager.getLayout(initialScrollIndex);
const initialItemOffset = this.propsRef.horizontal
? initialItemLayout.x
: initialItemLayout.y;
this.engagedIndicesTracker.scrollOffset = initialItemOffset;
} else {
// console.log("initialItemOffset", initialItemOffset, this.firstItemOffset);
const initialItemLayout = this.layoutManager.getLayout(0);
const initialItemOffset = this.propsRef.horizontal
? initialItemLayout.x
: initialItemLayout.y;
this.engagedIndicesTracker.scrollOffset =
(initialItemOffset ?? 0) - this.firstItemOffset;
initialItemOffset - this.firstItemOffset;
}
}

Expand Down