Android RN 0.73 Support - Update build.gradle w/ Namespace#879
Closed
alexhernandez wants to merge 2 commits intoShopify:mainfrom
Closed
Android RN 0.73 Support - Update build.gradle w/ Namespace#879alexhernandez wants to merge 2 commits intoShopify:mainfrom
alexhernandez wants to merge 2 commits intoShopify:mainfrom
Conversation
Contributor
|
Hey @alexhernandez can you please change the PR title to |
alexhernandez
changed the title
Author
|
@efstathiosntonas updated |
alexhernandez
changed the title
Author
|
@efstathiosntonas let me know if there is anything else I need to update on this MR 👍 |
|
Any plans on merging this now that react-native 0.73 RC1 is out? |
|
@alexhernandez have you accepted the CLA? |
|
A cleaner fix exists that also removes the user facing warning because it create a new separate manifest: |
Collaborator
|
@alexhernandez Can you accept the CLA so this can be merged? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RN Team Update:
react-native-community/discussions-and-proposals#671
Fix:
react-native-community/discussions-and-proposals#671 (comment)