Skip to content

Test & prep new Vite plugin-react #163

@jplhomer

Description

@jplhomer

See: vitejs/vite#5255

Which adjusts how Babel transforms JSX files from node_modules and adds the automatic JSX runtime.

I was able to add the new version by:

  • Checking out the Vite PR
  • pnpm dev inside the plugin-react package
  • cp over the dist contents to Hydrogen's node_modules for the plugin-react package

However, I'm seeing this error sometimes on the client when RSC tries to dynamically import client components:
Screen Shot 2021-11-08 at 2 33 42 PM

I'm curious if this is the result of the plugin changes or something else?

Perhaps because we're importing the raw ID and not allowing Vite to detect our client component imports?

@frandiox do you have any thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions