Bump connection_pool and Sidekiq #654
Merged
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mangara
force-pushed
the
mangara-bump-connection-pool
branch
from
806cce8 to
9827d28
Compare
Fix incompatibility for older tests.
Mangara
force-pushed
the
mangara-bump-connection-pool
branch
from
9827d28 to
1c62e7b
Compare
MatthewRBruce
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Connection pool 3.0 is incompatible with Sidekiq 8.0.9 and earlier.
This works for now, but I'm not a big fan of this approach, it's getting too complex. Different gemfiles for the different Ruby versions are likely a better solution.