Skip to content

Conversation

@dersam
Copy link
Contributor

@dersam dersam commented Jan 30, 2026

Closes #734

Copy link
Contributor Author

dersam commented Jan 30, 2026

@invocation.run!
end

assert @invocation.failed?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems a bit awkward there could even be the slightest possibility that failed? and completed? could be both true or false together, at the same time. This might or might not benefit this class's use case, but I'm curious if using an enum for these statuses could benefit here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion about this. I'd still like to have the predicate methods (more readable), the state enum would be an implementation detail.

Copy link
Contributor Author

dersam commented Jan 30, 2026

Merge activity

  • Jan 30, 6:27 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 30, 6:27 PM UTC: @dersam merged this pull request with Graphite.

@dersam dersam merged commit fc1bac5 into main Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cogs/agent/providers/claude/claude_invocation.rb

2 participants