Skip to content

Conversation

@vinistock
Copy link
Member

@vinistock vinistock commented Jun 26, 2025

Motivation

Closes #3628

If users place tests in directories that don't match our expected glob pattern convention, the files will not be discovered, but the code lenses might still be available. That will currently cause the buttons to do nothing with no feedback, which is not great.

Implementation

Started showing a message explaining why a test might have not been discovered, added a new note to our docs and linked to it.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock self-assigned this Jun 26, 2025
@vinistock vinistock added vscode This pull request should be included in the VS Code extension's release notes bugfix This PR will fix an existing bug labels Jun 26, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review June 26, 2025 13:36
@vinistock vinistock requested a review from a team as a code owner June 26, 2025 13:36
@alexcrocha
Copy link
Contributor

Hmm, if the code lens does not work can we avoid showing it instead?

Not opposed to the message if there's too much of a refactor involved.

@alexcrocha
Copy link
Contributor

Hmm, if the code lens does not work can we avoid showing it instead?

Not opposed to the message if there's too much of a refactor involved.

I just saw the other PR #3632. Allowing users to disable test code lenses is a good compromise.

Should we highlight this in the error message?

@vinistock vinistock force-pushed the 06-26-show_message_when_trying_to_run_a_test_that_hasn_t_been_discovered branch from 6c6b14a to bf049e4 Compare June 26, 2025 18:51
@vinistock
Copy link
Member Author

Hmm, if the code lens does not work can we avoid showing it instead?

I think this is a good idea. I pushed a new commit that checks against the same glob pattern as the extension. What do you think?

I just saw the other PR #3632. Allowing users to disable test code lenses is a good compromise.
Should we highlight this in the error message?

That one is actually not directly related to this. Some users wanted to disable the code lens and only use the buttons provided by the explorer tab.

@vinistock vinistock force-pushed the 06-26-show_message_when_trying_to_run_a_test_that_hasn_t_been_discovered branch from bf049e4 to a70ee6a Compare June 26, 2025 19:30
Copy link
Contributor

@alexcrocha alexcrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vinistock vinistock merged commit 630ab6b into main Jun 26, 2025
37 checks passed
@vinistock vinistock deleted the 06-26-show_message_when_trying_to_run_a_test_that_hasn_t_been_discovered branch June 26, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The test running buttons runs no longer seem to be funcational

2 participants