Skip to content

Conversation

@mrp089
Copy link
Member

@mrp089 mrp089 commented May 24, 2024

Current situation

Closes #110.

Release Notes

Adopted Codecov rules from svFSIplus via codecov.yml and bump upload action to v4.

Documentation

Codecov becomes informative only and won't prevent merging a PR that drops coverage.

Testing

Let's see if the action runs.

Code of Conduct & Contributing Guidelines

@codecov
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.82%. Comparing base (7c722a5) to head (4876b2c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   87.52%   77.82%   -9.70%     
==========================================
  Files          51       52       +1     
  Lines        1964     2034      +70     
  Branches        0      259     +259     
==========================================
- Hits         1719     1583     -136     
- Misses        245      451     +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrp089
Copy link
Member Author

mrp089 commented May 24, 2024

Works now as intended! The weird thing is it still uses tokenless upload:

evenName: pull_request
baseRef: SimVascular:master | headRef: mrp089:fix_codecov_110
==> Fork detected, tokenless uploading used

Maybe every user would need to add the token in their fork? In any case, I think this can be merged. @menon-karthik, once this is merged, update #109 to see the coverage.

@mrp089 mrp089 assigned mrp089 and unassigned mrp089 May 24, 2024
@mrp089 mrp089 requested a review from menon-karthik May 24, 2024 00:41
@menon-karthik
Copy link
Member

Ah I already merged #109 before seeing this! But it's ok, I will merge this now. Thanks @mrp089!

@menon-karthik menon-karthik merged commit 688cece into SimVascular:master May 24, 2024
@mrp089 mrp089 deleted the fix_codecov_110 branch May 24, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codecov stopped working

2 participants