Valve status output #203
Merged
Valve status output #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nh block, changed test cases to include new valve outputs
mrp089
requested changes
Nov 21, 2025
Member
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Thanks, @KatrinKoesler, very helpful! A few comments in the review
1 task
Member
|
Looks great, @KatrinKoesler! If you change the three small things in the documentation, it's good to merge. |
mrp089
requested changes
Dec 1, 2025
src/model/ValveTanh.h
Outdated
| * 0 & 0 & 0 & 0 | ||
| * \mathbf{E}^{e}=\left[\begin{array}{ccccc} | ||
| * 0 & 0 & 0 & 0 & 0 \\ | ||
| * 0 & 0 & 0 & 0 & 0 \\ |
src/model/ValveTanh.h
Outdated
| * \left[\begin{array}{ccccc} | ||
| * 0 & 0 & 0 & 0 & 0\\ | ||
| * 0 & 0 & 0 & 0 & 0\\ | ||
| * 0 & 0 & 0 & 0 & 0 |
src/model/ValveTanh.h
Outdated
| * \mathbf{F}^{e}=\left[\begin{array}{ccccc} | ||
| * 1 & -(R_{max}+R_{min})/2.0 & -1 & 0 & 0\\ | ||
| * 0 & 1 & 0 & -1 & 0\\ | ||
| * 0 & 0 & 0 & 7 & 1 |
mrp089
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added valve status as output
Current situation
Currently, there is no variable indicating whether a valve is open or closed in the output of the valve block. This would be an useful information to have when testing cardiovascular networks that include chambers and valves.
Release Notes
Testing
All tests run
Code of Conduct & Contributing Guidelines