Add hyperbolic tangent valve #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating from Master
mrp089
requested changes
Nov 29, 2023
Member
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Nice work, @menon-karthik! And thank you for fixing a bunch of unrelated things!
I have a few minor comments. My only concern is if we break something by introducing upstream/downstream vessels.
src/model/ValveTanh.h
Outdated
| * @brief Valve (tanh) block. | ||
| * | ||
| * Models the pressure drop across a diode-like valve, which is implemented as a | ||
| * non-linear hyperbolic-tangent resistor. See \cite pfaller2019importance. |
Member
There was a problem hiding this comment.
Add equation number to (questionable) reference?
Member
|
And nice work, @kharold23! Feel free to reply to the comments as well (if you want). |
mrp089
reviewed
Nov 29, 2023
Closed
mrp089
approved these changes
Dec 2, 2023
Member
|
Splendid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76
Added a hyperbolic tangent valve as described in #76.
I also made some other changes along the way:
BlockType,BlockFactory,ClosedLoopCoronaryRightandSimulationParameters(which weren't getting built by Doxygen before).InputParametersfromBlockTypetoParametersSimulationParametersto make it more readable